Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine 3.17 #392

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Alpine 3.17 #392

merged 1 commit into from
Nov 30, 2022

Conversation

Earlopain
Copy link
Contributor

https://alpinelinux.org/posts/Alpine-3.17.0-released.html

Alpine 3.17 ships with openssl3 by default. Ruby 2.7 and 3.0 only build with openssl1, but there is a compat package which can be installed. I'm assuming that this will also be a problem for future debian versions.

This also adds YJIT to the other alpine version, since that now has the correct rust version for that.

@tianon
Copy link
Member

tianon commented Nov 28, 2022

Nice, thank you for this!

I'll mirror part of docker-library/php#1348 (comment), since my opinion here is the same for the same reasons:

IMO we should "solve" this by only supporting Alpine 3.17+ for versions which support OpenSSL 3+ (no strong opinion either way from me on whether we drop 3.15 from all or just from those that get 3.17, but definitely no more than two Alpine versions for any given [Ruby] version). 🚀

(even though PHP itself happens to use a conflicting package as part of PHP itself so the build fails even with the compat package and Ruby doesn't, there will still be a negative downstream effect here that I think we should avoid)

I'm happy to take over from here if you'd prefer, or let you continue working on it. 👍

@Earlopain
Copy link
Contributor Author

Welcome back, hope you had a pleasant Thanksgiving!

I went with removing the 3.17 variants for 2.7 and 3.0. I think I put the logic for that in the right place, but feel free to correct.

@tianon
Copy link
Member

tianon commented Nov 29, 2022

Did a minor swap into versions.sh so that it's reflected in versions.json as well (and then apply-template.sh and generate-stackbrew-library.sh both do the right thing with a naive approach) 👍

@tianon tianon requested a review from yosifkit November 30, 2022 00:10
@yosifkit yosifkit merged commit fdb1345 into docker-library:master Nov 30, 2022
@Earlopain
Copy link
Contributor Author

Earlopain commented Nov 30, 2022

Duh, yeah. It makes much more sense there. Thanks.

docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Nov 30, 2022
Changes:

- docker-library/ruby@fdb1345: Merge pull request docker-library/ruby#392 from Earlopain/alpine3.17
- docker-library/ruby@a51b7da: Add Alpine 3.17
@Earlopain Earlopain deleted the alpine3.17 branch November 30, 2022 07:16
@yosifkit yosifkit mentioned this pull request Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants