bake: additional opts when parsing definition #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
bake-parse-opts
branch
from
eff806a to
0f41490
Compare
crazy-max
commented
Mar 26, 2024
crazy-max
force-pushed
the
bake-parse-opts
branch
5 times, most recently
from
f78f313 to
fdcc1cb
Compare
crazy-max
force-pushed
the
bake-parse-opts
branch
from
fdcc1cb to
3714847
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
bake-parse-opts
branch
from
3714847 to
416c291
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provenance,sbomandno-cacheopts were missing when parsing the definition.shm-sizeandulimitsattributes have been added toTargetstruct as well related to docker/buildx#2242Also adds
execOptionsopt that will be used in bake-action to handle specific options accordingly. This is related to docker/bake-action#193 where I was testing loading a remote bake definition from a private repo which doesn't give enough context when failing due tosilent: true.