Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bake: ulimits and shm-size support #2242

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

crazy-max
Copy link
Member

fixes #2241

@crazy-max crazy-max force-pushed the bake-ulimits-shmsize branch 6 times, most recently from 0bdee7c to 03edd08 Compare February 5, 2024 22:54
@crazy-max crazy-max added this to the v0.13.0 milestone Feb 9, 2024
@crazy-max crazy-max requested a review from tonistiigi February 9, 2024 09:30
@crazy-max crazy-max marked this pull request as ready for review February 9, 2024 09:30
Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions / some I am not sure about so feel free to dismiss if you disagree

docs/bake-reference.md Outdated Show resolved Hide resolved
docs/reference/buildx_build.md Show resolved Hide resolved
docs/reference/buildx_build.md Outdated Show resolved Hide resolved
docs/reference/buildx_build.md Outdated Show resolved Hide resolved
docs/reference/buildx_build.md Outdated Show resolved Hide resolved
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max force-pushed the bake-ulimits-shmsize branch from 57d2c29 to 73d8969 Compare February 20, 2024 10:29
Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonistiigi tonistiigi merged commit daaa8f2 into docker:master Feb 22, 2024
64 of 65 checks passed
@crazy-max crazy-max deleted the bake-ulimits-shmsize branch February 22, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buildx bake file doesn't support new ulimit directives
3 participants