history: input:context attribute support #3459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
history-input-context
branch
from
c44c84d to
11ee874
Compare
crazy-max
commented
Oct 8, 2025
| const recordsLimit = 50 | ||
|
|
||
| func buildName(fattrs map[string]string, ls *localstate.State) string { | ||
| func BuildName(fattrs map[string]string, ls *localstate.State) string { |
Member
Author
There was a problem hiding this comment.
expose build name for desktop build backend
tonistiigi
reviewed
Oct 8, 2025
commands/history/utils.go
Outdated
| } else if v, ok := fattrs["vcs:localdir:context"]; ok && v != "." { | ||
| contextPath = filepath.ToSlash(v) | ||
| } else if v, ok := fattrs["input:context"]; ok && !build.IsRemoteURL(v) { | ||
| contextPath = filepath.ToSlash(v) |
Member
Author
There was a problem hiding this comment.
Ah yes I was thinking we might have a future case where it's a path but not necessary here. Removed.
crazy-max
force-pushed
the
history-input-context
branch
from
11ee874 to
23c3c87
Compare
tonistiigi
reviewed
Oct 9, 2025
commands/history/utils.go
Outdated
| if v, ok := fattrs["vcs:source"]; ok { | ||
| vcsSource = v | ||
| } else if v, ok := fattrs["input:context"]; ok && build.IsRemoteURL(v) { | ||
| vcsSource = v |
Member
There was a problem hiding this comment.
Did you want to update this to the fragment-style URL?
Member
Author
There was a problem hiding this comment.
Yes will do, I'm looking to make a public func on BuildKit side as it will be used on both side
crazy-max
force-pushed
the
history-input-context
branch
from
23c3c87 to
4adc666
Compare
crazy-max
force-pushed
the
history-input-context
branch
from
4adc666 to
4bf7b02
Compare
crazy-max
force-pushed
the
history-input-context
branch
from
4bf7b02 to
02ecae9
Compare
crazy-max
force-pushed
the
history-input-context
branch
from
02ecae9 to
c6ca12a
Compare
crazy-max
force-pushed
the
history-input-context
branch
from
c6ca12a to
14e571b
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
history-input-context
branch
from
14e571b to
c40f9d9
Compare
tonistiigi
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs moby/buildkit#6284follow-up #3415