dfgitutil: FragmentFormat func #6284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
git-fragment-format-func
branch
from
d7f3f09 to
e894482
Compare
tonistiigi
reviewed
Oct 10, 2025
util/gitutil/git_url.go
Outdated
|
|
||
| // FragmentFormat returns a simplified git URL in fragment format with only ref. | ||
| // If the URL cannot be parsed, the original string is returned with false. | ||
| func FragmentFormat(remote string) (string, bool) { |
Member
There was a problem hiding this comment.
I think this should be in the dfgitutil pkg. Maybe unit test as well.
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
git-fragment-format-func
branch
from
e894482 to
0888dc4
Compare
crazy-max
changed the title
tonistiigi
approved these changes
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed by docker/buildx#3459