Skip to content

Update CircleCI Docker version to 18.09.3 #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thaJeztah merged 2 commits into from
Jul 18, 2019
Merged

Update CircleCI Docker version to 18.09.3 #1599

thaJeztah merged 2 commits into from
Jul 18, 2019

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jan 4, 2019

18.03 has reached EOL; let's use a current version in CI as well

@thaJeztah thaJeztah requested a review from dnephin January 4, 2019 21:06
thaJeztah
thaJeztah commented Jan 4, 2019
View reviewed changes
circle.yml Outdated
version: 18.03.1-ce
reusable: true
exclusive: false
version: 18.09.0
Copy link
Member Author

@thaJeztah thaJeztah Jan 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the Circle-CI images did not yet update the version-scheme; the Docker versions no longer have a -ce / -ee suffix

Allocating a remote Docker Engine
failed to create host: rpc error: code = Unknown desc = image docker-18.09.0 is not supported

/cc @dnephin perhaps they should have an alias?

@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 4, 2019

oh... no 18.09.0-ce either 🤔 perhaps without .0 (

Allocating a remote Docker Engine
failed to create host: rpc error: code = Unknown desc = image docker-18.09.0-ce is not supported

Interesting; the documentation (https://circleci.com/docs/2.0/building-docker-images/#docker-version) refers to the static linux packages;

screen shot 2019-01-04 at 22 14 44

Which then "should" be able to use docker-18.09.0 as name

screen shot 2019-01-04 at 22 13 45

Perhaps it's because the latest version dropped the docker- prefix from some binaries? (i.e., it's now runc, containerd instead of docker-runc, docker-containerd)

@dnephin
Copy link
Contributor

dnephin commented Jan 4, 2019

There is no 18.09 image yet for setup_remote_docker, docker-18.06.0-ce is the latest.

@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 4, 2019

Ah, that's a pity. No 18.06.1 either?

@codecov-io
Copy link

codecov-io commented Jan 4, 2019

Codecov Report

Merging #1599 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1599   +/-   ##
=======================================
  Coverage   55.33%   55.33%           
=======================================
  Files         283      283           
  Lines       19305    19305           
=======================================
  Hits        10682    10682           
  Misses       7927     7927           
  Partials      696      696

@codecov-io
Copy link

codecov-io commented Jan 4, 2019 •
edited
Loading

Codecov Report

Merging #1599 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1599   +/-   ##
=======================================
  Coverage   56.74%   56.74%           
=======================================
  Files         310      310           
  Lines       21802    21802           
=======================================
  Hits        12371    12371           
  Misses       8517     8517           
  Partials      914      914

@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 4, 2019

related discussion on the CircleCI forum; https://discuss.circleci.com/t/docker-18-09-support-for-setup-remote-docker/26731

@thaJeztah thaJeztah changed the title Update CircleCI Docker version to 18.09.0 Update CircleCI Docker version to 18.06.0 Jan 4, 2019
@thaJeztah thaJeztah force-pushed the bump_docker_for_ci branch 3 times, most recently from c805330 to af05a7e Compare March 2, 2019 12:24
@thaJeztah thaJeztah force-pushed the bump_docker_for_ci branch 2 times, most recently from e6c0058 to fc0e2b4 Compare July 10, 2019 15:00
thaJeztah added 2 commits July 10, 2019 17:09
@thaJeztah
Circle-CI: fix indentation in circle.yml
53fc63a 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Update CircleCI Docker version to 18.09.3
8b19c1d 
18.03 has reached EOL; let's use a more current version in CI

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the bump_docker_for_ci branch from 5aaf617 to 8b19c1d Compare July 10, 2019 15:10
@thaJeztah thaJeztah changed the title Update CircleCI Docker version to 18.06.0 Update CircleCI Docker version to 18.09.3 Jul 10, 2019
@thaJeztah
Copy link
Member Author

thaJeztah commented Jul 10, 2019

18.09.3 is now available (no more current versions yet, but at least we should now also be able to use BuildKit where needed; I'll have a look at that after

@thaJeztah thaJeztah mentioned this pull request Jul 18, 2019
Merged
silvin-lubecki
silvin-lubecki approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member Author

thaJeztah commented Jul 18, 2019

I'll go ahead and merge

@thaJeztah thaJeztah merged commit 5a3b015 into docker:master Jul 18, 2019
@thaJeztah thaJeztah deleted the bump_docker_for_ci branch July 18, 2019 19:13
@thaJeztah thaJeztah mentioned this pull request Aug 15, 2019
Merged
@thaJeztah thaJeztah added this to the 20.03.0 milestone Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@silvin-lubecki silvin-lubecki silvin-lubecki approved these changes

@dnephin dnephin Awaiting requested review from dnephin

Assignees

No one assigned

Labels

area/testing process/cherry-picked status/2-code-review

Projects

None yet

Milestone

20.10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@thaJeztah @dnephin @codecov-io @silvin-lubecki @GordonTheTurtle