CircleCI/Jenkins: use buildkit #2009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2009 +/- ##
=======================================
Coverage 56.79% 56.79%
=======================================
Files 311 311
Lines 21836 21836
=======================================
Hits 12402 12402
Misses 8519 8519
Partials 915 915 |
thaJeztah
force-pushed
the
ci_buildkit
branch
3 times, most recently
from
f364b59 to
0919b9b
Compare
| @@ -1,2 +1,6 @@ | |||
| .dockerignore | |||
Contributor
There was a problem hiding this comment.
That's super meta 😸
Member
Author
There was a problem hiding this comment.
I usually add the Dockerfile itself as well, didn't take time to look into which Dockerfile may be used docker-in-docker
thaJeztah
added
process/cherry-pick
status/2-code-review
and removed
status/0-triage
labels
tiborvass
reviewed
Jul 18, 2019
tiborvass
approved these changes
Jul 19, 2019
Collaborator
|
TestSigProxyWithTTY timed out twice in a row. |
Member
Author
Yes. It's flaky for some reason, but I'm unable to reproduce it locally 😞 almost seems machine-specific (help welcome!) |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #1599rebased