Support SCTP port mapping #278
Conversation
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
=======================================
Coverage 53.21% 53.21%
=======================================
Files 258 258
Lines 16346 16346
=======================================
Hits 8699 8699
Misses 7082 7082
Partials 565 565 |
|
I see the PR in go-connections is docker/go-connections#41 Let's merge that first, then we can update this PR to vendor the actual go-connections repository instead of a fork. |
|
@aaronlehmann Sure. I'll update this PR after docker/go-connections#41 get merged. However, I think moby/libnetwork#1825 is the first PR we need to merge for SCTP port mapping feature. |
|
rebased |
|
Ok, but let's not merge this until the moby/moby PR is merged. |
AkihiroSuda
force-pushed
the
sctp
branch
2 times, most recently
from
a224f0e
to
513e958
Compare
|
Perhaps we want to update the tests for #581 to include SCTP |
|
moby/moby#33922 was merged |
opts/port.go
Outdated
| @@ -49,7 +49,8 @@ func (p *PortOpt) Set(value string) error { | |||
|
|
|||
| switch key { | |||
| case portOptProtocol: | |||
| if value != string(swarm.PortConfigProtocolTCP) && value != string(swarm.PortConfigProtocolUDP) { | |||
| // TODO: use swarm.PortConfigProtocolSCTP (vendor moby/moby#33922) | |||
There was a problem hiding this comment.
Looks like we just need to vendor this in now?
|
Opened a vendor PR for moby/moby: #892 |
|
Will rebase soon after #892 gets merged, thanks |
Signed-off-by: Wataru Ishida <ishida.wataru@lab.ntt.co.jp> Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
|
done |
|
Thanks @AkihiroSuda - this does need a follow-up to update the documentation, for example, the |
The "kubernetes" and "swarm" annotations are removed as we don't want to hide stack command. Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
Signed-off-by: Wataru Ishida ishida.wataru@lab.ntt.co.jp
- What I did
This PR add support for SCTP port mapping.
Please see moby/moby#33922 for the details.
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)