Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Kubernetes stack support #3166

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Deprecate Kubernetes stack support #3166

merged 1 commit into from
Jun 28, 2021

Conversation

mat007
Copy link
Member

@mat007 mat007 commented Jun 28, 2021

Signed-off-by: Mathieu Champlon mathieu.champlon@docker.com

- What I did

Added depreciation notice for Kubernetes support in docker stack.

Related to #2967

- How I did it

- How to verify it

- Description for the changelog

Kubernetes support for docker stack is now deprecated.

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Mathieu Champlon <mathieu.champlon@docker.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah added this to the 21.xx milestone Jun 28, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3166 (7190255) into master (8e08b72) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3166   +/-   ##
=======================================
  Coverage   57.09%   57.09%           
=======================================
  Files         299      299           
  Lines       18731    18731           
=======================================
  Hits        10695    10695           
  Misses       7166     7166           
  Partials      870      870           

@thaJeztah thaJeztah merged commit cfeab9c into docker:master Jun 28, 2021
@thaJeztah
Copy link
Member

Can you open a cherry-pick PR in the 20.10 branch as well?

When cherry-picking, make sure to use the -x and -s options (cherry-pick -s -x 7190255a68018af93ea29f2213c0b3874f554943), so that there's a reference to the original commit in the cherry-pick commit 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants