Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/command/context: remove deprecated k8s / orchestrator option-stubs #4366

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

thaJeztah
Copy link
Member

relates to:

support for kubernetes contexts was deprecated in docker 20.10 through b639ea8, 0793f96, and 1d37fb3, and removed altoghether in 23.0 through 193ede9.

This patch removes the remaining stubs for options that were deprecated and no longer used.

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

Codecov Report

Merging #4366 (41b12a4) into master (8181aa8) will increase coverage by 0.06%.
The diff coverage is 0.00%.

❗ Current head 41b12a4 differs from pull request most recent head 2133d04. Consider uploading reports for the commit 2133d04 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4366      +/-   ##
==========================================
+ Coverage   59.29%   59.35%   +0.06%     
==========================================
  Files         288      288              
  Lines       24770    24744      -26     
==========================================
  Hits        14688    14688              
+ Misses       9198     9172      -26     
  Partials      884      884              

@thaJeztah thaJeztah force-pushed the remove_deprecated_context_stubs branch from 41b12a4 to 7a0faa1 Compare June 21, 2023 09:38
support for kubernetes contexts was deprecated in docker 20.10 through
b639ea8, 0793f96,
and 1d37fb3, and removed altoghether in
23.0 through 193ede9.

This patch removes the remaining stubs for options that were deprecated
and no longer used.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the remove_deprecated_context_stubs branch from 7a0faa1 to 2133d04 Compare June 21, 2023 09:39
@thaJeztah
Copy link
Member Author

Flaky test: #4356

#19 95.87 === FAIL: cli/connhelper/commandconn TestCloseRunningCommand (5.00s)
#19 95.87     commandconn_unix_test.go:62: assertion failed: 5 (int) != 0 (n int)
#19 95.87     commandconn_unix_test.go:63: assertion failed: error is not nil: write |1: broken pipe
#19 95.87     commandconn_unix_test.go:74: test did not finish in time

Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@thaJeztah thaJeztah merged commit 27bae11 into docker:master Jun 28, 2023
@thaJeztah thaJeztah deleted the remove_deprecated_context_stubs branch June 28, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants