Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.10 backport] CI: update engine versions and Jenkins labels #3176

Merged
merged 3 commits into from
Jul 2, 2021

Conversation

thaJeztah
Copy link
Member

To fix CI in this branch (see #3174 (comment))

Backports #3137

The dind engine version that we use in e2e does not support cgroups v2,
so if we landed on an Ubuntu 20.04 node with cgroups v2 enabled, CI failed:

    Stderr:   Error response from daemon: cgroups: cgroup mountpoint does not exist: unknown

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 2849437)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 661b87a)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
20.10.6 looks to be the latest supported version:
https://circleci.com/docs/2.0/building-docker-images/#docker-version

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit c6cd049)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

@silvin-lubecki @mat007 PTAL

@codecov-commenter
Copy link

Codecov Report

Merging #3176 (644c003) into 20.10 (063e3dd) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            20.10    #3176      +/-   ##
==========================================
+ Coverage   57.06%   57.07%   +0.01%     
==========================================
  Files         299      299              
  Lines       18691    18691              
==========================================
+ Hits        10666    10668       +2     
+ Misses       7157     7156       -1     
+ Partials      868      867       -1     

Copy link
Member

@mat007 mat007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@thaJeztah thaJeztah merged commit 8279b71 into docker:20.10 Jul 2, 2021
@thaJeztah thaJeztah deleted the 20.10_backport_update_ci_engine branch July 2, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants