Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go to 1.17 #3258

Closed
wants to merge 1 commit into from
Closed

update go to 1.17 #3258

wants to merge 1 commit into from

Conversation

tonistiigi
Copy link
Member

Removes the platform-based switch between different versions.

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

Removes the platform based switch between different versions.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #3258 (9de2e44) into master (e3dfc24) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3258   +/-   ##
=======================================
  Coverage   57.99%   57.99%           
=======================================
  Files         302      302           
  Lines       21748    21748           
=======================================
  Hits        12613    12613           
  Misses       8212     8212           
  Partials      923      923           

@thaJeztah
Copy link
Member

We should check if moby/moby also builds with go 1.17. The release pipeline currently assumes the same version is used for both

@thaJeztah thaJeztah mentioned this pull request Aug 19, 2021
Copy link
Collaborator

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go 1.17 on macOS requires golang/sys@a76c4d0 (May 8) or later.

The current version in vendor.conf is golang/sys@d19ff85 (Apr 27)

@thaJeztah
Copy link
Member

opened moby/moby#42777 to test moby on go 1.17

@thaJeztah
Copy link
Member

opened #3269 to update golang.org/x/sys in this repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants