update go to 1.17 #3383
Merged
update go to 1.17 #3383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
commented
Dec 8, 2021
Comment on lines
9
to
15
| FROM --platform=$BUILDPLATFORM tonistiigi/xx:${XX_VERSION} AS xx | ||
|
|
||
| FROM go-${TARGETOS} AS build-base-alpine | ||
| FROM --platform=$BUILDPLATFORM golang:${GO_VERSION}-${BASE_VARIANT} AS build-base-alpine | ||
| COPY --from=xx / / | ||
| RUN apk add --no-cache bash clang lld llvm file git | ||
| WORKDIR /go/src/github.com/docker/cli |
There was a problem hiding this comment.
I was looking at these stages, and it appears we're not using the alpine stages anywhere? (perhaps I overlooked though 🤔)
|
Looks like this is failing; |
Codecov Report
@@ Coverage Diff @@
## master #3383 +/- ##
==========================================
- Coverage 59.01% 59.00% -0.01%
==========================================
Files 284 282 -2
Lines 23833 23830 -3
==========================================
- Hits 14066 14062 -4
Misses 8908 8908
- Partials 859 860 +1 |
|
okay; this looks ✅ now @crazy-max @silvin-lubecki PTAL (please double check if I didn't miss something in the Dockerfile changes) |
|
@thaJeztah Needs to fix buster target too otherwise: $ make -f docker.Makefile dynbinary
...
#5 [internal] load metadata for docker.io/library/go-linux:latest
#5 ERROR: pull access denied, repository does not exist or may require authorization: authorization status: 401: authorization failed
------
> [internal] load metadata for docker.io/library/go-linux:latest:
------
Dockerfile:21
--------------------
19 | RUN xx-apk add --no-cache musl-dev gcc
20 |
21 | >>> FROM go-${TARGETOS} AS build-base-buster
22 | COPY --from=xx / /
23 | RUN apt-get update && apt-get install --no-install-recommends -y bash clang lld fileReplace Line 32 in 548fd20 With FROM --platform=$BUILDPLATFORM golang:${GO_VERSION}-${BASE_VARIANT} AS build-base-busterWe should add a step in the build matrix to cover that. Can be done in follow-up. Edit: PR opened #3384 |
thaJeztah
force-pushed
the
bump_go_117
branch
from
52f2d68
to
0bbd906
Compare
FROM --platform=$BUILDPLATFORM golang:${GO_VERSION}-${BASE_VARIANT} AS build-base-busterActually looking now if we need to use Also; guess we should be updating to |
thaJeztah
force-pushed
the
bump_go_117
branch
from
0bbd906
to
f69dfd2
Compare
|
@thaJeztah |
|
🤦 thought I could just a quick find/replace. Of course I could expect that 😅 |
thaJeztah
force-pushed
the
bump_go_117
branch
from
ad7d497
to
d3487d5
Compare
|
Hmmm... this looks like something we need to fix; are we missing the |
|
Actual failure is in this bit though; |
Closed
|
Looks like my last commit fixed the osusergo issue, but this one is still remaining; |
This was referenced Mar 26, 2022
Removes the platform based switch between different versions. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
changed the title
|
I removed the update to debian bullseye from this PR, and the other fixes ( After this is merged, I'll also look at using |
crazy-max
approved these changes
Mar 26, 2022
|
Let's get this one in; I'll open a PR for the debian update, and will have a look at updating |
|
opened #3493 for the debian step |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
carries / closes #3258
Removes the platform based switch between different versions.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)