Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: update xx to 1.1 #3489

Merged
merged 1 commit into from
Mar 26, 2022
Merged

Conversation

thaJeztah
Copy link
Member

splitting up #3383 (where we're debugging some issues with cross compiles); moving this to a separate PR so that we can test/merge some changes in isolation.

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@thaJeztah thaJeztah added this to the 21.xx milestone Mar 26, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3489 (40d8016) into master (87b8e57) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3489   +/-   ##
=======================================
  Coverage   59.01%   59.01%           
=======================================
  Files         284      284           
  Lines       23833    23833           
=======================================
  Hits        14066    14066           
  Misses       8908     8908           
  Partials      859      859           

@thaJeztah
Copy link
Member Author

thaJeztah commented Mar 26, 2022

FTR, so the osusergo issue is indeed already present in current builds (so not new in #3383);

#37 399.9 /usr/bin/s390x-linux-gnu-ld: /tmp/go-link-800461440/000018.o: in function `mygetgrouplist':
#37 399.9 /usr/local/go/src/os/user/getgrouplist_unix.go:16: warning: Using 'getgrouplist' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking

@thaJeztah
Copy link
Member Author

thx!

@thaJeztah thaJeztah merged commit 3897c3f into docker:master Mar 26, 2022
@thaJeztah thaJeztah deleted the dockerfile_update_xx branch March 26, 2022 14:57
@thaJeztah
Copy link
Member Author

We should fix this; or does xx also have a apt-get ? apt meant for "humans", and not meant for scripting (see the warning);

#54 [linux/amd64 build-buster 1/1] RUN xx-apt install --no-install-recommends -y libc6-dev libgcc-8-dev
#54 0.706 Hit:1 http://security.debian.org/debian-security buster/updates InRelease
#54 0.707 Hit:2 http://deb.debian.org/debian buster InRelease
#54 0.708 Hit:3 http://deb.debian.org/debian buster-updates InRelease
#54 2.149 Reading package lists...
#54 4.917 + apt  install --no-install-recommends -y libc6-dev libgcc-8-dev
#54 4.934 
#54 4.934 WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
#54 4.934 

@crazy-max
Copy link
Member

crazy-max commented Mar 26, 2022

Yes xx has xx-apt-get: tonistiigi/xx#40

@thaJeztah
Copy link
Member Author

@thaJeztah
Copy link
Member Author

opened #3491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants