Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go v1.18 #3473

Closed
wants to merge 1 commit into from
Closed

Upgrade to Go v1.18 #3473

wants to merge 1 commit into from

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Mar 16, 2022

- What I did
Bump go to v1.18 in project

- How I did it
Just changed go version and updated vendor, using CI to check anything breaks

- How to verify it
isn't this what CI is for :P

- Description for the changelog
docker CLI is now built with Go v1.18

- A picture of a cute animal (not mandatory but encouraged)
16473647905303633413105380353441

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@DasSkelett
Copy link

I suspect the work in #3383 has to be completed before an update to 1.18 can be considered.

I also don't think blindly bumping the go directive in go.mod makes sense, until features from Go 1.18 are used.

@ndeloof
Copy link
Contributor Author

ndeloof commented Mar 20, 2022

as noted, the goal of this draft PR was just to check the potential impact, so we have a better idea about the missing bits before we can benefit from go 1.18 features

@ndeloof ndeloof closed this Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants