cli/config: remove warning for deprecated ~/.dockercfg file #4281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This FIXME was added in 2013 in moby/moby@c72ff31 and it's both unclear which "internal golang config parser" is referred to here. Given that 10 Years have passed, this will unlikely happen, and doesn't warrant a FIXME here. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The `~/.dockercfg` file was replaced by `~/.docker/config.json` in 2015 (github.com/docker/docker/commit/18c9b6c6455f116ae59cde8544413b3d7d294a5e). Commit b83bc67 (v23.0.0, but backported to v20.10) added a warning if no "current" config file was found but a legacy file was, and if the CLI would fall back to using the deprecated file. Commit ee218fa removed support for the legacy file, but kept a warning in place if a legacy file was in place, and now ignored. This patch removes the warning as well, fully deprecating the legacy `~/.dockercfg` file. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
impact/changelog
impact/deprecation
status/2-code-review
kind/refactor
|
@rumpl @laurazard ptal |
vvoland
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli/config: Load: remove outdated FIXME
This FIXME was added in 2013 in moby/moby@c72ff31
and it's both unclear which "internal golang config parser" is referred to here. Given that 10 Years have passed, this will unlikely happen, and doesn't warrant a FIXME here.
cli/config: remove warning for deprecated ~/.dockercfg file
The
~/.dockercfgfile was replaced by~/.docker/config.jsonin 2015(github.com/docker/docker/commit/18c9b6c6455f116ae59cde8544413b3d7d294a5e).
Commit b83bc67 (#2666) (v23.0.0, but backported to v20.10) added a warning if no "current" config file was found but a legacy file was, and if the CLI would fall back to using the deprecated file.
Commit ee218fa (#2504) removed support for the legacy file, but kept a warning in place if a legacy file was in place, and now ignored.
This patch removes the warning as well, fully deprecating the legacy
~/.dockercfgfile.- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)