Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli/config: remove warning for deprecated ~/.dockercfg file #4281

Merged
merged 2 commits into from
May 16, 2023
Merged

cli/config: remove warning for deprecated ~/.dockercfg file #4281

merged 2 commits into from
May 16, 2023

Commits on May 10, 2023

  1. cli/config: Load: remove outdated FIXME 

    This FIXME was added in 2013 in moby/moby@c72ff31
and it's both unclear which "internal golang config parser" is referred to
here. Given that 10 Years have passed, this will unlikely happen, and doesn't
warrant a FIXME here.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed May 10, 2023
    Configuration menu
    Copy the full SHA
    9b791b4 View commit details
    Browse the repository at this point in the history

  2. cli/config: remove warning for deprecated ~/.dockercfg file 

    The `~/.dockercfg` file was replaced by `~/.docker/config.json` in 2015
(github.com/docker/docker/commit/18c9b6c6455f116ae59cde8544413b3d7d294a5e).

Commit b83bc67 (v23.0.0, but backported to
v20.10) added a warning if no "current" config file was found but a legacy
file was, and if the CLI would fall back to using the deprecated file.

Commit ee218fa removed support for the
legacy file, but kept a warning in place if a legacy file was in place,
and now ignored.

This patch removes the warning as well, fully deprecating the legacy
`~/.dockercfg` file.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed May 10, 2023
    Configuration menu
    Copy the full SHA
    379122b View commit details
    Browse the repository at this point in the history