Move Docker Trust out of experimental #935
Conversation
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
vieux
force-pushed
the
trust-out-of-experimental2
branch
from
fa8060d
to
ac35e85
Compare
|
This also requires the code changes to remove it from experimental, for example; Line 16 in 2731c71 |
|
And possibly documentation changes |
Codecov Report
@@ Coverage Diff @@
## master #935 +/- ##
==========================================
- Coverage 53.92% 53.91% -0.01%
==========================================
Files 262 262
Lines 16605 16600 -5
==========================================
- Hits 8954 8950 -4
Misses 7050 7050
+ Partials 601 600 -1 |
|
@thaJeztah I don't understand your comment, |
|
oh, never mind, I thought there were more locations it was in 😊 but we only put it on the root ( |
There was a problem hiding this comment.
code LGTM
but we need some updates in the docs, (e.g. https://github.com/docker/cli/blob/master/docs/reference/commandline/trust_view.md needs to be merged with the "inspect" docs)
thaJeztah
added
impact/changelog
status/2-code-review
kind/experimental
docs/revisit
and removed
status/0-triage
labels
|
@thaJeztah I pushed a doc update here |
| ### Get details about signatures for a single image tag | ||
|
|
||
| ```bash | ||
| $ docker trust inspect --pretyy alpine:latest |
|
|
||
| The administrative keys listed specify the root key of trust, as well as the administrative repository key. These keys are responsible for modifying signers, and rotating keys for the signed repository. | ||
|
|
||
| If signers are set up for the repository via other `docker trust` commands, `docker trust inspect --pretty` displays them appropriately as a `SIGNER` and specify their `KEYS`: |
There was a problem hiding this comment.
can you wrap these lines to 80 chars?
|
|
||
| The `SIGNED TAG` is the signed image tag with a unique content-addressable `DIGEST`. `SIGNERS` lists all entities who have signed. | ||
|
|
||
| The administrative keys listed specify the root key of trust, as well as the administrative repository key. These keys are responsible for modifying signers, and rotating keys for the signed repository. |
There was a problem hiding this comment.
can you wrap these lines to 80 chars?
| Administrative keys for my-image: | ||
| Repository Key: 27df2c8187e7543345c2e0bf3a1262e0bc63a72754e9a7395eac3f747ec23a44 | ||
| Root Key: 40b66ccc8b176be8c7d365a17f3e046d1c3494e053dd57cfeacfe2e19c4f8e8f | ||
| ``` |
There was a problem hiding this comment.
please add a newline at the end
Signed-off-by: Victor Vieux <victorvieux@gmail.com>
vieux
force-pushed
the
trust-out-of-experimental2
branch
from
8c906ce
to
09ec6d4
Compare
|
@thaJeztah I addressed your comments |
Signed-off-by: Nassim 'Nass' Eddequiouaq eddequiouaq.nassim@gmail.com
This is a follow-up on #934 which moves
docker trust viewtodocker trust inspect --pretty.- What I did
Moved
docker trustcommands out of experimental- How to verify it
Run
docker trustcommands successfully without "experimental" enabled in the CLIconfig.json.- Description for the changelog
Moved Docker Trust commands out of experimental.
Important: This PR shouldn't be merged before #934