Bash: update trust completions #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @vieux @andrewhsu |
thaJeztah
commented
Mar 14, 2018
contrib/completion/bash/docker
Outdated
| @@ -4711,11 +4711,25 @@ _docker_tag() { | |||
| } | |||
|
|
|||
|
|
|||
| _docker_trust_inspect() { | |||
There was a problem hiding this comment.
oh, hold on, this one needs to be moved a couple of lines down
thaJeztah
force-pushed
the
update-completion-scripts
branch
from
517f935
to
5180994
Compare
The `docker trust` commands were moved out of experimental, and the `docker trust view` command was changed to `docker trust inspect --pretty`. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
update-completion-scripts
branch
from
5180994
to
2a6808d
Compare
thaJeztah
commented
Mar 14, 2018
| case "$cur" in | ||
| -*) | ||
| COMPREPLY=( $( compgen -W "--help --yes -y" -- "$cur" ) ) |
There was a problem hiding this comment.
Diff view on github looks a bit odd here, because the order of commands was changed (they're alphabetical, so order changed due to view -> inspect)
Codecov Report
@@ Coverage Diff @@
## master #944 +/- ##
==========================================
- Coverage 53.92% 53.92% -0.01%
==========================================
Files 262 262
Lines 16604 16604
==========================================
- Hits 8954 8953 -1
- Misses 7049 7050 +1
Partials 601 601 |
|
ping @albers PTAL 🤗 |
|
Sorry for not waiting for you @albers - this had to go into the 18.03 release; let me know if there's things to address in this change |
|
I'm currently at a conference, will review when I'm back.
|
|
Thanks! You’re the best |
|
LGTM |
|
Thanks for reviewing 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(relates to #934 and #935)
The
docker trustcommands were moved out of experimental, and thedocker trust viewcommand was changed todocker trust inspect --pretty.- How to verify it
Build, and start a dev-container
Start bash, install bash-completion, and load the completion script:
Then try completions;
which should complete to
docker trust inspect --pretty- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)