Don't use "info.IndexServerAddress" for authentication #10458
Conversation
The IndexServerAddress field was as part of the initial Windows implementation of the engine. For legal reasons, Microsoft Windows (and thus Docker images based on Windows) were not allowed to be distributed through non-Microsoft infrastructure. As a temporary solution, a dedicated "registry-win-tp3.docker.io" registry was created to serve Windows images. Using separate registries was not an ideal solution, and a more permanent solution was created by introducing "foreign image layers" in the distribution spec, after which the "registry-win-tp3.docker.io" ceased to exist, and removed from the engine. This replaces the code that calls out to the "/info" endpoint to use the GetAuthConfigKey() function instead. Related PR in docker/cli: docker/cli@b4ca1c7 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10458 +/- ##
==========================================
- Coverage 59.76% 52.44% -7.32%
==========================================
Files 105 105
Lines 9074 9053 -21
==========================================
- Hits 5423 4748 -675
- Misses 3080 3791 +711
+ Partials 571 514 -57
... and 25 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
LOL, I don't understand CodeCov's reports. Looks like my PR "improves" coverage for the files I touched, but it considers "indirect" changes to reduce coverage 🤷 |
|
@thaJeztah The codecov setup is in a slightly broken state right now, we've been working to get E2E coverage etc properly incorporated. You can safely ignore it for the moment, sorry about that! |
|
Yeah, CodeCov (in my experience) often is a bit hit-and-miss. Sometimes useful, sometimes completely off 😞 Thanks! |
The IndexServerAddress field was as part of the initial Windows implementation of the engine. For legal reasons, Microsoft Windows (and thus Docker images based on Windows) were not allowed to be distributed through non-Microsoft infrastructure. As a temporary solution, a dedicated "registry-win-tp3.docker.io" registry was created to serve Windows images.
Using separate registries was not an ideal solution, and a more permanent solution was created by introducing "foreign image layers" in the distribution spec, after which the "registry-win-tp3.docker.io" ceased to exist, and removed from the engine.
This replaces the code that calls out to the "/info" endpoint to use the GetAuthConfigKey() function instead.
Related PR in docker/cli:
docker/cli@b4ca1c7
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did