Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use "info.IndexServerAddress" for authentication #10458

Merged
merged 1 commit into from
Apr 12, 2023

Commits on Apr 11, 2023

  1. Don't use "info.IndexServerAddress" for authentication

    The IndexServerAddress field was  as part of the initial Windows implementation
    of the engine. For legal reasons, Microsoft Windows (and thus Docker images
    based on Windows) were not allowed to be distributed through non-Microsoft
    infrastructure. As a temporary solution, a dedicated "registry-win-tp3.docker.io"
    registry was created to serve Windows images.
    
    Using separate registries was not an ideal solution, and a more permanent
    solution was created by introducing "foreign image layers" in the distribution
    spec, after which the "registry-win-tp3.docker.io" ceased to exist, and
    removed from the engine.
    
    This replaces the code that calls out to the "/info" endpoint to use the
    GetAuthConfigKey() function instead.
    
    Related PR in docker/cli:
    docker/cli@b4ca1c7
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    1892be8 View commit details
    Browse the repository at this point in the history