Include all networks in ContainerCreate call if API >= 1.44

[laurazard]

Previously, we included the container's primary network in the ContainerCreate API call, and then connected the created container to each extra network one-by-one, by calling NetworkConnect.

However, starting API version 1.44 (moby/moby#45906), the ContainerCreate endpoint now takes multiple networks, allowing us to just include all the network configurations there and skip connecting the container to each extra network separately.

What I did

Change composeService.createMobyContainer to include all the network configurations for the container in the ContainerCreate call and skip connecting the container to networks individually, when API version >= 1.44.

Also added some tests to make sure we don't break this for <1.44.

(a good callout here is that currently, afaik, Compose isn't being tested against different Engine versions in CI, so it may be worth it to do that soon/wait on that before merging this PR)

(not mandatory) A picture of a cute animal, if possible in relation to what you did

[codecov]

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (6ef55a5) 58.09% compared to head (0fbdb93) 58.08%.

Files	Patch %	Lines
pkg/compose/convergence.go	66.66%	4 Missing and 2 partials ⚠️
pkg/compose/create.go	89.28%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11429      +/-   ##
==========================================
- Coverage   58.09%   58.08%   -0.02%     
==========================================
  Files         136      136              
  Lines       11543    11565      +22     
==========================================
+ Hits         6706     6717      +11     
- Misses       4177     4185       +8     
- Partials      660      663       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ndeloof]

LGTM as a general feature but I'm not a big fan we cover such an improvement with unit tests relying on API mocks. As we start relying on 1.25 features we need to run real tests on multiple engine versions

[laurazard]

Yup! I wrote in the PR test:

(a good callout here is that currently, afaik, Compose isn't being tested against different Engine versions in CI, so it may be worth it to do that soon/wait on that before merging this PR)

Probably a good change regardless :')

[milas]

LGTM! Want to rebase to pick up #11459? and then we can mergeeee

[laurazard]

Sorry, just saw this @milas! Rebased :)

[laurazard]

cc @glours if you want to TAL

[glours]

Sounds good to me 👍

[laurazard]

It's failing on a ddev test:

Failed to start 004: ddev-router failed to become ready; debug with 'docker logs ddev-router'; logOutput=, err=health check timed out: labels map[com.docker.compose.service:ddev-router] timed out without becoming healthy, status=

which I think might be flaky, but I don't have permissions to restart the test to check.
@ndeloof @glours can you TAL?

[glours]

CI was stuck, I restarted the whole workflow

[glours]

Ok we forgot to change the checks since we introduced the tests against 2 Docker engine versions @ndeloof 😅