Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include all networks in ContainerCreate call if API >= 1.44 #11429

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Include all networks in ContainerCreate call if API >= 1.44 #11429

merged 1 commit into from
Feb 7, 2024

Commits on Feb 7, 2024

  1. Include all networks in ContainerCreate call if API >= 1.44 

    Previously, we included the container's primary network in the
ContainerCreate API call, and then connected the created container
to each extra network one-by-one, by calling NetworkConnect.

However, starting API version 1.44, the ContainerCreate endpoint now
takes multiple EndpointsConfigs, allowing us to just include all the
network configurations there and skip connecting the container to each
extra network separately.

Signed-off-by: Laura Brehm <laurabrehm@hey.com>
    @laurazard
    laurazard committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    0fbdb93 View commit details
    Browse the repository at this point in the history