-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for every build context type supported by the daemon #1244
Conversation
@@ -12,6 +12,7 @@ RUN set -ex; \ | |||
curl \ | |||
lxc \ | |||
iptables \ | |||
liblzma-dev \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit; indentation looks off
ping @aanand. Any word on whether this is being considered for merging? Thanks! |
Thanks for the PR! I'm theoretically in support of the feature, but:
|
|
@aanand Moved |
@@ -12,6 +12,7 @@ RUN set -ex; \ | |||
curl \ | |||
lxc \ | |||
iptables \ | |||
liblzma-dev \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How widely installed is liblzma? We should make sure it exists on all the main already-supported Linux distros and OS X.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is a leftover from when context.py was in compose, there's no actual need for this dependency here. The lzma compression is handled as a special case in docker-py now: under py3 the tarfile module has built-in support for lzma (presuming the xz-utils headers were available when interpreter was built) but under py2 docker-py just accepts a file with an '.xz' extension as a lzma compressed tarball and passes it on to the build call without 'peeking' into it.
Signed-off-by: Moysés Borges <moysesb@gmail.com>
Signed-off-by: Moysés Borges <moysesb@gmail.com>
This is a Proposal PR.
Implements #1209 (and more) using some of the ideas from docker/docker-py#538
This changeset adds support for specifying the build path in any of the formats supported by docker-py's implementation of the build() operation. I expanded the section on
build:
in docs/yml.md with a brief explanation of what kind of values are supported. The implementation is mostly in a new file:compose/context.py
.