Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building contexts objects #589

Closed
wants to merge 1 commit into from
Closed

Add support for building contexts objects #589

wants to merge 1 commit into from

Conversation

moysesb
Copy link

@moysesb moysesb commented May 7, 2015

This PR implements #538 and is necessary for docker-compose PR docker/compose#1244



INVALID_CONTEXT_FORMAT_LONG_FMT = """
Build context at %s is not supported by docker-compose\\n
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably just say "Docker" 😏

@aanand
Copy link
Contributor

aanand commented May 8, 2015

  1. How much of this logic is actually implemented in the Docker client? For example, validation of the Dockerfile seems to happen on the server side. We don't need to go beyond what the Docker client implements.
  2. Documentation would be great.

@moysesb
Copy link
Author

moysesb commented May 8, 2015

@aanand

  1. Scaled back the validation to be just on access rights, Dockerfile name check and tarball format. The docker go client does roughly that level of validation; it supports reading a compressed context from stdin and should implicitly reject a malformed tarball (not sure about whether it actually rejects it, but I'd consider it the right thing to do).
  2. Added documentation at docs/context.md

@aanand
Copy link
Contributor

aanand commented May 8, 2015

Thanks. Looking good.

Signed-off-by: Moysés Borges <moysesb@gmail.com>
@moysesb moysesb closed this Sep 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants