Bail out immediately if there are legacy containers #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanand
force-pushed
the
abort-on-legacy-containers
branch
2 times, most recently
from
bae72ad to
a9cac7b
Compare
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
aanand
force-pushed
the
abort-on-legacy-containers
branch
from
a9cac7b to
0b4d940
Compare
aanand
referenced
this pull request
in aanand/fig
May 26, 2015
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
|
LGTM |
1 similar comment
|
LGTM |
bfirsh
added a commit
that referenced
this pull request
May 26, 2015
Bail out immediately if there are legacy containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sits on top of #1440.
If there are legacy containers, then in almost all cases it's not safe to keep doing whatever we were about to do. Additionally, the error output was pretty difficult to read.
I've changed it so we display a single message with all the names, plus directions for removing the containers if the user doesn't want to migrate, and then exit.