Migrate containers in dependency order #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanand
force-pushed
the
migrate-in-dependency-order
branch
2 times, most recently
from
bf2028c to
3fae80b
Compare
aanand
force-pushed
the
migrate-in-dependency-order
branch
from
3fae80b to
7714675
Compare
aanand
referenced
this pull request
in aanand/fig
May 26, 2015
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
This fixes a bug where migration would fail with an error if a downstream container was migrated before its upstream dependencies, due to `check_for_legacy_containers()` being implicitly called when we fetch `links`, `volumes_from` or `net` dependencies. Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
aanand
force-pushed
the
migrate-in-dependency-order
branch
from
7714675 to
7da8e6b
Compare
| containers = client.containers(all=stopped) | ||
|
|
||
| for service in services: | ||
| for container in containers: |
There was a problem hiding this comment.
Ok, so if I understand this correctly, the change here is that now we're iterating over things in the order of the passed in services, instead of just the container list order (which is basically undefined).
We have to assume the services were passed in the correct order, but that's probably safe to assume, since that's how we store them generally.
Does that sound right?
There was a problem hiding this comment.
Yes, sorry, the actual fix is a bit subtle - it relies on the fact that Project keeps its services in order, and so project.service_names returns them in order. That's a widely relied-upon constraint, though, so I don't think this is brittle.
|
LGTM |
aanand
added a commit
that referenced
this pull request
May 26, 2015
Migrate containers in dependency order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sits on top of #1441.
This fixes a bug introduced by #1441 where migration would fail with an error if a downstream container was migrated before its upstream dependencies (e.g. web before db), due to
check_for_legacy_containers()being implicitly called when we fetchlinks,volumes_fromornetdependencies.