Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker build --pull command. #1494

Closed
wants to merge 1 commit into from

Conversation

glogiotatidis
Copy link

This waits for docker/docker-py#624

@glogiotatidis
Copy link
Author

Interestingly docker-py defaults to pull=True. I suggested that this gets changed to match docker cli docker/docker-py#622.

Even more interestingly pull=True does not work. I reported the issue here moby/moby#13631.

@dnephin
Copy link

dnephin commented Aug 7, 2015

Resolves #726 and will replace #731

@dnephin
Copy link

dnephin commented Aug 27, 2015

Looks like the latest build is reporting a syntax error, but I don't see it in the diff. If you have a chance to rebase this on master, it would be good to get this in.

@thaJeztah
Copy link
Member

I see tests are still failing;

compose/service.py - Could not parse ast

    Traceback (most recent call last):
      File "/tmp/.pre-commit/repo7MclqR/py_env-default/lib/python2.7/site-packages/pre_commit_hooks/debug_statement_hook.py", line 38, in check_file_for_debug_statements
        ast_obj = ast.parse(open(filename).read(), filename=filename)
      File "/usr/local/lib/python2.7/ast.py", line 37, in parse
        return compile(source, filename, mode, PyCF_ONLY_AST)
      File "compose/service.py", line 725
        pull=pull,
    SyntaxError: keyword argument repeated

Fix End of Files.........................................................Passed
Flake8...................................................................Failed
hookid: flake8

compose/service.py:725:1: E901 SyntaxError: keyword argument repeated
tests/integration/cli_test.py:116:6: F821 undefined name 'patch'

Signed-off-by: Giorgos Logiotatidis <seadog@sealabs.net>
@glogiotatidis
Copy link
Author

@thaJeztah code updated. I still get errors but I need a hint to fix them.

@dnephin
Copy link

dnephin commented Aug 31, 2015

@glogiotatidis don't worry about this error, we have it ticketed as #1922

LGTM

@dnephin
Copy link

dnephin commented Sep 18, 2015

Done in #2041

@dnephin dnephin closed this Sep 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants