Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build() should default to pull=False #622

Closed
glogiotatidis opened this issue Jun 1, 2015 · 3 comments
Closed

Build() should default to pull=False #622

glogiotatidis opened this issue Jun 1, 2015 · 3 comments
Milestone
1.3.0

Comments

@glogiotatidis
Copy link
Contributor

The default behavior of docker cli when building does not pull by default. You must provide the --pull flag. I suggest that docker-py follows the same rule and default to pull=False

https://github.com/docker/docker-py/blob/master/docker/client.py#L309
@glogiotatidis glogiotatidis mentioned this issue Jun 1, 2015
Closed
@TomasTomecek
Copy link
Contributor

+1

@glogiotatidis
Copy link
Contributor Author

btw pull parameter doesn't do anything with current released version (1.6) of docker due to moby/moby#13631

jpopelka added a commit to jpopelka/atomic-reactor that referenced this issue Jun 1, 2015
@jpopelka
DockerTasker:build_image_from_path() - specify 'pull' arg of docker.C…
f2a594c 
…lient().build()

It defaults to True (might change in future, docker/docker-py#622).

Set it to False as we pull base image ourselves with InsideBuilder.pull_base_image()
jpopelka added a commit to jpopelka/atomic-reactor that referenced this issue Jun 1, 2015
@jpopelka
DockerTasker:build_image_from_path() - specify 'pull' arg of docker.C…
21ed55b 
…lient().build()

It defaults to True (might change in future, docker/docker-py#622).

Set it to False as we pull base image ourselves with InsideBuilder.pull_base_image()
jpopelka added a commit to jpopelka/atomic-reactor that referenced this issue Jun 2, 2015
@jpopelka
DockerTasker:build_image_from_path() - specify 'pull' arg of docker.C…
ae59dd6 
…lient().build()

It defaults to True (might change in future, docker/docker-py#622).

Set it to False as we pull base image ourselves with InsideBuilder.pull_base_image()
jpopelka added a commit to containerbuildsystem/atomic-reactor that referenced this issue Jun 2, 2015
@jpopelka @TomasTomecek
DockerTasker:build_image_from_path() - specify 'pull' arg of docker.C…
e9b8ba7 
…lient().build()

It defaults to True (might change in future, docker/docker-py#622).

Set it to False as we pull base image ourselves with InsideBuilder.pull_base_image()
@shin- shin- modified the milestone: 1.3.0 Jun 16, 2015
@shin-
Copy link
Contributor

shin- commented Jun 18, 2015

Fixed by #624

@shin- shin- closed this as completed Jun 18, 2015
@aanand aanand mentioned this issue Jun 19, 2015
Closed
@shin- shin- mentioned this issue Jun 29, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
3 participants
@glogiotatidis @shin- @TomasTomecek