Implement restart command (Closes #98)

[marksteve]

No description provided.

[d11wtq]

Thanks for this. Looks nice and straightforward. Would you mind adding a short integration test?

[marksteve]

👌

[marksteve]

@d11wtq Rebased with master :)

[d11wtq]

LGTM 👍

[aanand]

This doesn't seem to preserve links for me. If I run the homepage example:

$ fig up -d
Recreating homepage_redis_1...
Recreating homepage_web_1...

$ curl boot2docker:5000
Hello World! I have been seen 7 times.

$ fig restart
Restarting homepage_web_1...
Restarting homepage_redis_1...

$ curl boot2docker:5000
...error output...

Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1836, in __call__
    return self.wsgi_app(environ, start_response)
  File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1820, in wsgi_app
    response = self.make_response(self.handle_exception(e))
  File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1403, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1817, in wsgi_app
    response = self.full_dispatch_request()
  File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1477, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1381, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1475, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1461, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/code/app.py", line 9, in hello
    redis.incr('hits')
  File "/usr/local/lib/python2.7/site-packages/redis/client.py", line 842, in incr
    return self.execute_command('INCRBY', name, amount)
  File "/usr/local/lib/python2.7/site-packages/redis/client.py", line 534, in execute_command
    connection.send_command(*args)
  File "/usr/local/lib/python2.7/site-packages/redis/connection.py", line 532, in send_command
    self.send_packed_command(self.pack_command(*args))
  File "/usr/local/lib/python2.7/site-packages/redis/connection.py", line 508, in send_packed_command
    self.connect()
  File "/usr/local/lib/python2.7/site-packages/redis/connection.py", line 412, in connect
    raise ConnectionError(self._error_message(e))
ConnectionError: Error 113 connecting to redis_1:6379. No route to host.

Is the order of restarting wrong?

[marksteve]

@aanand Oops. Just followed the kill method. Removed the reversed call.

[aanand]

LGTM

[aanand]

Hm, strike that - getting an integration test failure.

$ nosetests tests.integration.cli_test:CLITestCase.test_restart
F
======================================================================
FAIL: test_restart (tests.integration.cli_test.CLITestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/aanand/work/orchard/fig/tests/integration/cli_test.py", line 201, in test_restart
    self.assertEqual(len(containers), 1)
AssertionError: 0 != 1
-------------------- >> begin captured logging << --------------------
requests.packages.urllib3.connectionpool: INFO: Starting new HTTP connection (1): 192.168.59.103
requests.packages.urllib3.connectionpool: DEBUG: "POST /v1.12/images/create?tag=latest&fromImage=busybox HTTP/1.1" 200 None
requests.packages.urllib3.connectionpool: DEBUG: "GET /v1.12/containers/json?all=1&limit=-1&trunc_cmd=1&size=0 HTTP/1.1" 200 None
requests.packages.urllib3.connectionpool: DEBUG: "GET /v1.12/images/json?only_ids=0&all=0 HTTP/1.1" 200 None
requests.packages.urllib3.connectionpool: INFO: Starting new HTTP connection (1): 192.168.59.103
requests.packages.urllib3.connectionpool: DEBUG: "GET /v1.12/containers/json?all=1&limit=-1&trunc_cmd=1&size=0 HTTP/1.1" 200 None
requests.packages.urllib3.connectionpool: DEBUG: "POST /v1.12/containers/create?name=simplefigfile_simple_1 HTTP/1.1" 201 90
requests.packages.urllib3.connectionpool: DEBUG: "GET /v1.12/containers/d1ddd9ceff1f1be60dfbe3ce3fd66a7b7445b3d97f350a30c0dd279b15c10d52/json HTTP/1.1" 200 1350
requests.packages.urllib3.connectionpool: INFO: Starting new HTTP connection (1): 192.168.59.103
requests.packages.urllib3.connectionpool: DEBUG: "GET /v1.12/containers/json?all=0&limit=-1&trunc_cmd=1&size=0 HTTP/1.1" 200 2
requests.packages.urllib3.connectionpool: DEBUG: "GET /v1.12/containers/json?all=0&limit=-1&trunc_cmd=1&size=0 HTTP/1.1" 200 2
requests.packages.urllib3.connectionpool: DEBUG: "GET /v1.12/containers/json?all=0&limit=-1&trunc_cmd=1&size=0 HTTP/1.1" 200 2
--------------------- >> end captured logging << ---------------------

----------------------------------------------------------------------
Ran 1 test in 4.259s

FAILED (failures=1)

[marksteve]

@aanand Sorry. Forgot that CI was no longer running integration tests. I didn't try testing locally :P Fixed the test.

[aanand]

LGTM

[prologic]

+1

[marksteve]

Ping

[bfirsh]

LGTM