Docker 1.2 - New functionality

[xeor]

Docker v1.2 just got released and brings in some new functionality which needs to be incorporated into fig.

As far as I can see, fig now lacks support for:

• --restart
• --cap-add
• --cap-drop
• --device

See http://blog.docker.com/2014/08/announcing-docker-1-2-0/ for the announcement.

[prologic]

+1 I may in fact try to address this and submit a PR for this.

[dnephin]

Support probably needs to be added to docker-py first (at least for some of these). #363, it would be nice if we could do this in a way that doesn't require special handling of every param and instead just passes it along to docker-py.

[prologic]

I agree. I'll be looking at docker-py as well...
On Aug 25, 2014 7:30 AM, "Daniel Nephin" notifications@github.com wrote:

Support probably needs to be added to docker-py first (at least for some
of these). #363 #363, it would be
nice if we could do this in a way that doesn't require special handling of
every param and instead just passes it along to docker-py.

—
Reply to this email directly or view it on GitHub
#434 (comment).

[bfirsh]

#477 will help with this!

[TFenby]

Capabilities added in #623
Device isn't available in docker-py 0.5.3
Didn't want to deal with restart.

[dnephin]

Restart was added in #393

[thaJeztah]

@dnephin Nope, #393 implements a restart command for fig.

This issue is about setting restart-policies on containers, which were introduced in Docker 1.2.

[prologic]

I'd like to see something like this in the fig.yml:

service:
build: .
command: ...
restart: always

For example. Where the value passed to "restart" matches what Docker
accepets.

cheers
James

James Mills / prologic

E: prologic@shortcircuit.net.au
W: prologic.shortcircuit.net.au

On Mon, Nov 10, 2014 at 7:08 PM, Sebastiaan van Stijn <
notifications@github.com> wrote:

@dnephin https://github.com/dnephin Nope, #393
#393 implements a restart command
for fig.

This issue is about setting restart-policies on containers, which were
introduced in Docker 1.2
https://blog.docker.com/2014/08/announcing-docker-1-2-0/.

—
Reply to this email directly or view it on GitHub
#434 (comment).

[TFenby]

The only question would be how the retry count of on-failure should be expressed in yml.
Needs to end up as { "Name": "on-failure", "MaximumRetryCount": 3 }

[dnephin]

@thaJeztah you're right, I got the wrong ticket. It should have been #594 which is not merged yet

[thaJeztah]

@dnephin Oh, yes. There's a pull request, forgot about that.

In which case, this issue is a duplicate of #478 (or the other way around, because this one was frist)

[paulRbr]

@TFenby expressed the same way it's done in the cli of docker : https://github.com/docker/fig/pull/594/files#diff-ebf882803c8eac5a345368609d88cd80R374 without forgetting the quotes of course :)

i.e. restart: "on-failure:3"

[bfirsh]

Only thing left is device which I have mentioned in #754. Thanks!