Add capability add/drop introduced in Docker 1.2 #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whups, tests failed. Jussasec. |
|
Thanks @TFenby! Would you mind squashing those two commits and adding documentation? https://github.com/docker/fig/blob/master/CONTRIBUTING.md#tldr |
|
Done and done. Splitting code/doc commits is a personal preference, but I'll squash them as well if you prefer. |
|
LGTM |
|
Still look good? :) |
|
Yup, still looks good, but needs another LGTM from someone else to merge. I've put it into the milestone for the next release. |
|
Thanks @TFenby! Looks awesome. This needs rebasing though, unfortunately. |
TFenby
force-pushed
the
capabilities
branch
2 times, most recently
from
1c96462 to
5c58180
Compare
Signed-off-by: Tyler Fenby <tylerfenby@gmail.com>
|
@bfirsh: Done |
|
Awesome. |
|
LGTM |
bfirsh
added a commit
that referenced
this pull request
Dec 8, 2014
Add capability add/drop introduced in Docker 1.2
|
Thanks @TFenby! |
yuval-k
pushed a commit
to yuval-k/compose
that referenced
this pull request
Apr 10, 2015
Add capability add/drop introduced in Docker 1.2 Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tyler Fenby tylerfenby@gmail.com