Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] rpm: fix missing GOTOOLCHAIN=local in centos, rhel Dockerfiles #1062

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

thaJeztah
Copy link
Member

Commit a4090a0 added GOTOOLCHAIN=local, but for some reason missed the centos Dockerfiles.

The env-var is set to make sure we don't get unexpected updates of the go toolchain when building. We need to set this env-var, because we're not using the official golang image as base-image, but instead copy the binaries into a distro-image.

This patch adds the missing GOTOOLCHAIN env-vars.

Commit a4090a0 added GOTOOLCHAIN=local,
but for some reason missed the centos Dockerfiles.

The env-var is set to make sure we don't get unexpected updates of the go
toolchain when building. We need to set this env-var, because we're not using
the official golang image as base-image, but instead copy the binaries into
a distro-image.

This patch adds the missing GOTOOLCHAIN env-vars.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@vvoland vvoland merged commit 462b265 into docker:master Sep 4, 2024
7 checks passed
@thaJeztah thaJeztah deleted the fix_gotoolchain_env branch September 4, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants