[master] rpm, deb: fix Dockerfile linting issues #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit d61915e addressed these warnings for the deb-based Dockerfiles, but didn't update the rpm ones; - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 13) - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 15) - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 16) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The `GO_IMAGE` build-arg doesn't have a default;
- InvalidDefaultArgInFrom: Default value for ARG ${GO_IMAGE} results in empty or invalid base image name (line 8)
This is not a real issue when building using the Makefiles (which is how
these Dockerfiles are expected to be used) but we can probably set a
default.
This patch sets the default to `golang:latest` to pick the latest version,
which should be fine for this (until we get a linter recommending not
to use `:latest`).
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
fix_dockerfile_linting
branch
from
6958712
to
9c73210
Compare
thaJeztah
changed the title
thaJeztah
changed the title
vvoland
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENV key valueformat #1047rpm: fix Dockerfile legacy ENV key value format linting warnings
commit d61915e addressed these warnings
for the deb-based Dockerfiles, but didn't update the rpm ones;
deb,rpm: fix Dockerfile default value for ARG linting warnings
The
GO_IMAGEbuild-arg doesn't have a default;This is not a real issue when building using the Makefiles (which is how
these Dockerfiles are expected to be used) but we can probably set a
default.
This patch sets the default to
golang:latestto pick the latest version,which should be fine for this (until we get a linter recommending not
to use
:latest).