-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A new user-focused API #1186
Merged
Merged
A new user-focused API #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfirsh
force-pushed
the
two-point-oh
branch
17 times, most recently
from
September 9, 2016 14:42
1c50e24
to
bf71a46
Compare
bfirsh
force-pushed
the
two-point-oh
branch
7 times, most recently
from
September 9, 2016 16:37
c035c21
to
d073d77
Compare
bfirsh
force-pushed
the
two-point-oh
branch
from
September 12, 2016 09:12
d073d77
to
7d621f8
Compare
Just do Client(version='auto'). Signed-off-by: Ben Firshman <ben@firshman.co.uk>
Signed-off-by: Ben Firshman <ben@firshman.co.uk>
Signed-off-by: Ben Firshman <ben@firshman.co.uk>
Signed-off-by: Ben Firshman <ben@firshman.co.uk>
For some reason this was spread across two files. Signed-off-by: Ben Firshman <ben@firshman.co.uk>
So the cleanup stuff can be reused for model tests. Signed-off-by: Ben Firshman <ben@firshman.co.uk>
Signed-off-by: Ben Firshman <ben@firshman.co.uk>
CONTRIBUTING.md is the place that GitHub expects it to be. Signed-off-by: Ben Firshman <ben@firshman.co.uk>
Signed-off-by: Ben Firshman <ben@firshman.co.uk>
See docker#1086 Signed-off-by: Ben Firshman <ben@firshman.co.uk>
Initial work thanks to @aanand. Signed-off-by: Ben Firshman <ben@firshman.co.uk>
Signed-off-by: Ben Firshman <ben@firshman.co.uk>
The only thing that's outstanding to me still is this thread: #1186 (comment) But I think we can address it separately before the release. Let's go ahead and merge this. 👍 |
This was referenced Nov 26, 2016
This was referenced Nov 28, 2016
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation of #1086.
Todo
Nice to have
requires_api_version
on integration tests, etc)AutoVersionAPIClient
in favour of justversion='auto'
?ImageNotFoundError
instead of method onAPIError
Client
, but does onAPIClient
.