Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new user-focused API #1186

Merged
merged 17 commits into from
Nov 23, 2016
Merged

A new user-focused API #1186

merged 17 commits into from
Nov 23, 2016

Conversation

bfirsh
Copy link
Contributor

@bfirsh bfirsh commented Sep 6, 2016

An implementation of #1086.

Todo

  • Thorough unit tests for new API
  • Add run options which span both create and host config (e.g. ports and volumes)
  • Full set of integration tests for containers
  • Implement complete set of methods for images with integration tests
  • Add remaining objects to new API
  • Documentation
  • Add docstrings
  • Better service options?
  • Handle image methods that apply to multiple tags on a repository.
  • Squash commits a bit

Nice to have

@bfirsh bfirsh force-pushed the two-point-oh branch 17 times, most recently from 1c50e24 to bf71a46 Compare September 9, 2016 14:42
@bfirsh bfirsh force-pushed the two-point-oh branch 7 times, most recently from c035c21 to d073d77 Compare September 9, 2016 16:37
@shin- shin- added this to the 2.0.0 milestone Sep 10, 2016
Just do Client(version='auto').

Signed-off-by: Ben Firshman <ben@firshman.co.uk>
Signed-off-by: Ben Firshman <ben@firshman.co.uk>
Signed-off-by: Ben Firshman <ben@firshman.co.uk>
Signed-off-by: Ben Firshman <ben@firshman.co.uk>
For some reason this was spread across two files.

Signed-off-by: Ben Firshman <ben@firshman.co.uk>
So the cleanup stuff can be reused for model tests.

Signed-off-by: Ben Firshman <ben@firshman.co.uk>
Signed-off-by: Ben Firshman <ben@firshman.co.uk>
CONTRIBUTING.md is the place that GitHub expects it to be.

Signed-off-by: Ben Firshman <ben@firshman.co.uk>
Signed-off-by: Ben Firshman <ben@firshman.co.uk>
See docker#1086

Signed-off-by: Ben Firshman <ben@firshman.co.uk>
Initial work thanks to @aanand.

Signed-off-by: Ben Firshman <ben@firshman.co.uk>
Signed-off-by: Ben Firshman <ben@firshman.co.uk>
@shin-
Copy link
Contributor

shin- commented Nov 23, 2016

The only thing that's outstanding to me still is this thread: #1186 (comment)

But I think we can address it separately before the release. Let's go ahead and merge this. 👍

@shin- shin- merged commit 8478491 into docker:master Nov 23, 2016
@bfirsh
Copy link
Contributor Author

bfirsh commented Nov 23, 2016

Yippee, thank you!

2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants