Update setup.py and things #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2016
It's not the Docker API. Signed-off-by: Ben Firshman <ben@firshman.co.uk>
Move from "docker-py" package to "docker". Signed-off-by: Ben Firshman <ben@firshman.co.uk>
It was missing docker.models, and this will fix it forever more. Signed-off-by: Ben Firshman <ben@firshman.co.uk>
Signed-off-by: Ben Firshman <ben@firshman.co.uk>
bfirsh
force-pushed
the
update-setup-py
branch
from
de6a8f1 to
fc9f7e2
Compare
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things here:
docker, rather thandocker-py. This wasn't explicitly mentioned in A new user-focused API #1186, but seems like like a sensible thing to me because:pip install docker-pywon't break when we release 2.0.pip install ...andimport ...are consistent.setup.pyfind_packagesinsetup.py2.0.0-dev