engine: warn more about insecure daemon configurations / deprecate non-tls tcp #19587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dvdksn
changed the title
thaJeztah
reviewed
Apr 3, 2024
thaJeztah
reviewed
Apr 3, 2024
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
warn-exposed-daemon
branch
from
4bb8d6f
to
e5552f3
Compare
craig-osterhout
approved these changes
Apr 29, 2024
| Note that even if you have a firewall to limit accesses to the REST API | ||
| endpoint from other hosts in the network, the endpoint can be still accessible | ||
| from containers, and it can easily result in the privilege escalation. | ||
| Therefore it is *mandatory* to secure API endpoints with | ||
| [HTTPS and certificates](protect-access.md). | ||
| Exposing the daemon API over HTTP without TLS is not permitted, | ||
| and such a configuration causes the daemon to fail early on startup, see |
There was a problem hiding this comment.
Nit: The , see here doesn't read smooth for me. Maybe use a period, like ...early on startup. For more information, see ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes the warnings about insecure configurations bigger and adds a note that a TCP socket without TLS is deprecated and will be removed
Related issues or tickets
moby/moby#47556
docker/cli#4928