-
Notifications
You must be signed in to change notification settings - Fork 7.8k
engine: warn more about insecure daemon configurations / deprecate non-tls tcp #19587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -103,20 +103,22 @@ arbitrary containers. | |
|
||
For this reason, the REST API endpoint (used by the Docker CLI to | ||
communicate with the Docker daemon) changed in Docker 0.5.2, and now | ||
uses a UNIX socket instead of a TCP socket bound on 127.0.0.1 (the | ||
uses a Unix socket instead of a TCP socket bound on 127.0.0.1 (the | ||
latter being prone to cross-site request forgery attacks if you happen to run | ||
Docker directly on your local machine, outside of a VM). You can then | ||
use traditional UNIX permission checks to limit access to the control | ||
use traditional Unix permission checks to limit access to the control | ||
socket. | ||
|
||
You can also expose the REST API over HTTP if you explicitly decide to do so. | ||
However, if you do that, be aware of the above mentioned security | ||
implications. | ||
However, if you do that, be aware of the above mentioned security implications. | ||
Note that even if you have a firewall to limit accesses to the REST API | ||
endpoint from other hosts in the network, the endpoint can be still accessible | ||
from containers, and it can easily result in the privilege escalation. | ||
Therefore it is *mandatory* to secure API endpoints with | ||
[HTTPS and certificates](protect-access.md). | ||
Exposing the daemon API over HTTP without TLS is not permitted, | ||
and such a configuration causes the daemon to fail early on startup, see | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: The |
||
[Unauthenticated TCP connections](../deprecated.md#unauthenticated-tcp-connections). | ||
It is also recommended to ensure that it is reachable only from a trusted | ||
network or VPN. | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.