-
Notifications
You must be signed in to change notification settings - Fork 2k
Conversation
@@ -8,7 +8,7 @@ RUN go get github.com/tools/godep | |||
RUN go get code.google.com/p/go.tools/cmd/cover | |||
|
|||
ENV GOPATH /go/src/github.com/docker/machine/Godeps/_workspace:/go | |||
ENV MACHINE_BINARY /go/src/github.com/docker/machine/docker-machine | |||
ENV MACHINE_BINARY /go/src/github.com/docker/machine/docker-machine/docker-machine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we just call this directory bin
to avoid confusion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a problem with go get
. go get
names the binary by whatever directory the main
package is in.
By putting it in a docker-machine
dir, we can ensure that people will have a binary called docker-machine
.
I'll need a little time to look it over thoroughly, but having just run into some issues with circular imports I'm very in favor of the direction. |
I'm still not fond of an |
@nathanleclaire there shouldn't be any import issues -- the tests pass and the binary builds. I will reset and see if I get the same. @sthulb I know :) I'm up for debate - it seemed to fit. |
@ehazlett Oh, I was commenting that I was running into circular imports with something (unrelated) that I was working on, and I think re-organizing might help with that. |
@nathanleclaire ah ok cool |
Signed-off-by: Evan Hazlett <ejhazlett@gmail.com>
…eate docker-machine package; update build script Signed-off-by: Evan Hazlett <ejhazlett@gmail.com>
2716df0
to
997ae82
Compare
This is a proposal / PR to make machine more maintainable. I want to get feedback on the direction. It does the following:
github.com/docker/machine
top level packagedocker-machine