Begin separation of creation and provisioning

[nathanleclaire]

• Implement methods to get SSH key path, port, username, and hostname
• Move hostname provisioning out of drivers and into main code path
• implement generic wait for SSH function like in @ggiamarchi PR Test SSH establishing a real SSH connection #665

cc @ehazlett @sthulb

Signed-off-by: Nathan LeClaire nathan.leclaire@gmail.com

[nathanleclaire]

Oh yes, and also I moved SaveConfig to be before provisioning, since provisioning is often the step where things go awry.

Next step is to remove IP polling and waiting for instance startup out of drivers' Create method.

[sthulb]

We could merge the two host name functions and supply a path to the hostname file.

[nathanleclaire]

I considered this but they are slightly different in other ways (mostly the /etc/hosts line) - is it okay to use the command from SetInstanceHostnameUbuntu in both styles?

[sthulb]

The B2D host won't mind.

[sthulb]

I agree we shouldn't do SSH commands from inside the driver.

Can you update the driver doc to mention SSH connection info must be exported?

I guess things like hostnames will be removed with cloudinit

[ehazlett]

I like a lot of these ideas just not in the patch bomb format. I've implemented some of the SSH operations in #756. I think we can take bits of this and open smaller PRs against the issues listed in the repo (i.e. #744, #699) - especially the SaveConfig stuff - that will help tremendously.

Thanks!