Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RunSqlDoctrineCommand command with latest doctrine/dbal #1169

Closed
wants to merge 1 commit into from
Closed

Fix RunSqlDoctrineCommand command with latest doctrine/dbal #1169

wants to merge 1 commit into from

Conversation

jdecool
Copy link
Contributor

@jdecool jdecool commented May 20, 2020

Proposal to fix #1168

To avoid the issue, I propose to restrict the version that can be retrieved as long as doctrine/dbal 2.11 is not released.

ostrolucky
ostrolucky requested changes May 20, 2020
View reviewed changes
Copy link
Member

@ostrolucky ostrolucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree with such proposal. It blocks update disregarding if you use this command. We should do a proper fix.

@ostrolucky ostrolucky mentioned this pull request May 20, 2020
Merged
@jdecool
Copy link
Contributor Author

jdecool commented May 21, 2020

@ostrolucky 👍 for your PR

@jdecool jdecool closed this May 21, 2020
@jdecool jdecool deleted the issue-1168 branch May 21, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ostrolucky ostrolucky ostrolucky requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdecool @ostrolucky