Add minimal compatibility with changes in DBAL 2.11 RunSqlCommand #1170
Conversation
Proper fix would be more involved, relying on interfaces in DBAL to not change, which we cannot assume won't happen at this point. Full, proper fix needs to be done once DBAL 2.11 API is stable. Such fix will probably involve deprecating our current command class as well, since DBAL one has everything our command added on top in past.
ostrolucky
force-pushed
the
dbal-2.12-runsql-command-fix
branch
from
c7091b5 to
86d2469
Compare
|
Its a shame that this wasnt applied to 1.10.x, as this bug popped up for me on Symfony 2.8. I overrode the class and applied the fix here, and its now working fine. But regardless, thanks for the help! |
|
Symfony 2.8?! You need to complain less and upgrade more! |
|
Thanks for your opinion, but that decision is ultimately not up to me, so I am limited with what I can do. |
|
I don't see issue updating 1.10 to 1.12.. |
I'd rather you add this issue to the arsenal of arguments you might already have to fight bad policies implemented in your company rather than come here and vent. To give you more of my opinion, I think if you feel powerless and need to vent that badly, you should consider changing companies (easier said than done, but who knows, maybe you can). |
|
Ok, unsure why Im receiving aggression.. all I said was thank you for the fix, just would have been better for me personally if it could have been applied to a version that supported Symfony 2.8, which >1.10 does not (1.11+ requires Symfony 3.x components according to packagist/composer). So again, thank you, I sorted out a solution with your help. |
If you insist, I think I can help you understand. Consider how your initial message might make us feel… it reads a lot like "thanks for this, not quite good enough for my particular case though, which is totally legitimate by the way", coming with unsolicited advice on what branch maintenance policy we should adopt. At the time this was written, even Symfony itself did no longer provide support for version 2.8: https://symfony.com/releases/2.8 Cannot imagine why you would expect us to provide that support. |
Fixes #1168 .
Supersedes #1169 .
Proper fix would be more involved, relying on interfaces in DBAL to not change, which we cannot assume won't happen at this point. Full, proper fix needs to be done once DBAL 2.11 API is stable. Such fix will probably involve deprecating our current command class as well, since DBAL one has everything our command added on top in past.