Remove workaround for testing with PHP 8 #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
remove-php8-workaround
branch
from
e06af0d to
532211d
Compare
We should use a version that is compatible with PHP 8
greg0ire
force-pushed
the
remove-php8-workaround
branch
from
532211d to
dc158f0
Compare
Now that all dependencies support it, it should not be necessary to pretend we are using PHP 7.4.
greg0ire
force-pushed
the
remove-php8-workaround
branch
from
dc158f0 to
f256c0d
Compare
SenseException
approved these changes
Feb 14, 2021
| @@ -29,11 +31,13 @@ public function testInstantiatingWithoutManagerRegistry() : void | |||
| if (PHP_VERSION_ID >= 80000) { | |||
| $this->expectExceptionMessage( | |||
| <<<'MESSAGE' | |||
| Doctrine\Bundle\DoctrineBundle\Command\DoctrineCommand::__construct(): Argument #1 ($doctrine) must be of type Doctrine\Persistence\ManagerRegistry, null given, called in /home/runner/work/DoctrineFixturesBundle/DoctrineFixturesBundle/Command/LoadDataFixturesDoctrineCommand.php on line 49 | |||
| Doctrine\Bundle\DoctrineBundle\Command\DoctrineCommand::__construct(): Argument #1 ($doctrine) must be of type Doctrine\Persistence\ManagerRegistry, null given, called in /home/runner/work/DoctrineFixturesBundle/DoctrineFixturesBundle/Command/LoadDataFixturesDoctrineCommand.php on line 51 | |||
There was a problem hiding this comment.
Is the line number relevant for the error message check? It seems like an unstable test when changes are happening.
There was a problem hiding this comment.
It is unstable indeed, I remember having to change it in the past. Let me try refactoring it.
greg0ire
force-pushed
the
remove-php8-workaround
branch
3 times, most recently
from
e040fa3 to
d3a471d
Compare
We no longer assert the file and the line number in the test, which should make it less flaky. Also, we regroup together the 2 cases which makes it easier to understand the only thing that changes is the form of the message we are trying to test.
greg0ire
force-pushed
the
remove-php8-workaround
branch
from
d3a471d to
ff1a572
Compare
|
It looks like the integration tests are flaky 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that all dependencies support it, it should not be necessary to
pretend we are using PHP 7.4. Implies upgrading the CS lib.