-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge release 3.4.1 into 3.5.x #358
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess this is the first time that I actually want to *remove* a link :-) But this one leads just one (!) screen down to a self-explanatory heading with the exact same wording. So I would say, it just adds noise.
Removing internal link
Migrate to ramsey/composer-install
The --prefer-lowest job fails with an error message that is different from the 7.1 job, and that seems to be related to dependency injection.
Bump symfony/dependency-injection
Used short array syntax
We should use a version that is compatible with PHP 8
Now that all dependencies support it, it should not be necessary to pretend we are using PHP 7.4.
We no longer assert the file and the line number in the test, which should make it less flaky. Also, we regroup together the 2 cases which makes it easier to understand the only thing that changes is the form of the message we are trying to test.
Remove workaround for testing with PHP 8
[Doc] Minor fix in a code example
Add metadata file for symfony.com
Reuse workflows and setup static analysis
Replace reference placeholder
add .gitattributes - exclude tests from archive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes for 3.4.1
3.4.x bugfix release (patch)
3.4.1
Improvement
356: Replace reference placeholder thanks to @greg0ire
355: Reuse workflows and setup static analysis thanks to @greg0ire
353: feat: add symfony 6 support thanks to @Chris53897
350: add .gitattributes - exclude tests from archive thanks to @iamvar
347: Add metadata file for symfony.com thanks to @greg0ire
345: [Doc] Minor fix in a code example thanks to @javiereguiluz
344: Remove workaround for testing with PHP 8 thanks to @greg0ire
343: Bump symfony/dependency-injection thanks to @greg0ire
342: Used short array syntax thanks to @samnela
341: Migrate to ramsey/composer-install thanks to @greg0ire
340: Removing internal link thanks to @ThomasLandauer