Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php 8 #383

Closed
wants to merge 1 commit into from
Closed

php 8 #383

wants to merge 1 commit into from

Conversation

psohm
Copy link

@psohm psohm commented Nov 27, 2020

doctrine/doctrine-migrations-bundle 2.1.2 requires php ^7.1 -> your PHP version (8.0.0) does not satisfy that requirement.

@greg0ire
Copy link
Member

Blocked by doctrine/migrations#980

@lepiaf
Copy link

lepiaf commented Dec 8, 2020

Hello!

Could you add php8.0 into testing matrix ?

https://github.com/doctrine/DoctrineMigrationsBundle/blob/2.2.x/.github/workflows/continuous-integration.yml#L28

jobs:
  phpunit:
    name: "PHPUnit"
    runs-on: "ubuntu-20.04"

    strategy:
      matrix:
        php-version:
          - "7.1"
          - "7.2"
          - "7.3"
          - "7.4"
+         - "8.0"

@greg0ire
Copy link
Member

greg0ire commented Dec 8, 2020

@lepiaf I tried, see the link above.

@stof stof mentioned this pull request Dec 15, 2020
@ghost
Copy link

ghost commented Dec 15, 2020

any news ? @lepiaf

@stof
Copy link
Member

stof commented Dec 15, 2020

Well, the news is the same than before: the bundle cannot add PHP 8 support until the library itself adds it. And as discussed in the referenced issue, doctrine/migrations is itself dependent on ocramius/proxy-manager releasing a version supporting PHP 8 (which was blocked by laminas/laminas-code until recently, but this one is now unblocked)

@martinssipenko
Copy link

laminas/laminas-code is still kind of a blocker as there is no release for the fix yet.

@alcaeus
Copy link
Member

alcaeus commented Dec 23, 2020

#390 will add this for 3.x.

@alcaeus alcaeus closed this Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants