[3.0] Add support for PHP 8 #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
php-8-support
branch
from
ac1376e to
f7ac3d0
Compare
alcaeus
force-pushed
the
php-8-support
branch
from
f7ac3d0 to
b31e69f
Compare
nicolas-grekas
approved these changes
Dec 23, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With doctrine/migrations 3.0.x-dev supporting PHP (see doctrine/migrations#1101), we can add support for PHP 8 in 3.0 here as well. PHP 8 support for 2.x is a different issue, as it requires significant work in the base library to make that compatible with PHP 8. At this time, we can't guarantee whether 2.x will be made to work on PHP 8 as well.