Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support of PHP < 7.4 #763

Merged
merged 1 commit into from
Feb 5, 2023
Merged

Drop support of PHP < 7.4 #763

merged 1 commit into from
Feb 5, 2023

Conversation

franmomu
Copy link
Contributor

As we did it in the ODM I think we can do the same for the 4.6.0 release.

@franmomu franmomu added the Task label Jan 13, 2023
@franmomu franmomu added this to the 4.6.0 milestone Jan 13, 2023
@franmomu franmomu mentioned this pull request Jan 13, 2023
Merged
SenseException
SenseException approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose PHP 7 will be completely dropped in 5.0.x.

@franmomu
Copy link
Contributor Author

Looking at the installs https://packagist.org/packages/doctrine/mongodb-odm-bundle/php-stats#4.5, 20% are still using 7.4, so I think we should keep it for now.

IonBazan
IonBazan approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@IonBazan IonBazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any specific PHP 7.4 features we can use in this bundle after this PR is merged?

@franmomu
Copy link
Contributor Author

franmomu commented Feb 5, 2023

Are there any specific PHP 7.4 features we can use in this bundle after this PR is merged?

Yeah, we can add types to private properties, I'll do it in another PR.

@franmomu franmomu merged commit 88af62c into doctrine:4.6.x Feb 5, 2023
@franmomu franmomu deleted the drop_php_less_7.4 branch February 5, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IonBazan IonBazan IonBazan approved these changes

@SenseException SenseException SenseException approved these changes

Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@franmomu @SenseException @IonBazan