Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've targeted 4.6.x because the template added to
ServiceGridFSRepository
.The ignored errors are because
while(true)
inCommand/TailCursorDoctrineODMCommand.php
which psalm thinks that the return type must benever
.- InContainerRepositoryFactory
, there is a$customRepositoryName
variable that with typeclass-string|null
and when doingif (! class_exists($customRepositoryName))
afterif ($customRepositoryName !== null)
, psalm saysAll possible types for this argument were invalidated
.AbstractType
which seems not accurate, so we better don't use them.psalm/symfony-plugin 5 requires php
7.4
, so we need #763 or remove this dependency if it's not really useful (it will if we pass a path to the compiled container in XML).