Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DocParser.php #36

Closed
wants to merge 1 commit into from
Closed

Update DocParser.php #36

wants to merge 1 commit into from

Conversation

janschoenherr
Copy link
Contributor

@stof
Copy link
Member

stof commented Jul 9, 2014

please add a test covering the issue to avoid regressions

@janschoenherr
Copy link
Contributor Author

i've created a second pull request with a test here: #37

@janschoenherr janschoenherr mentioned this pull request Jul 9, 2014
Closed
@stof
Copy link
Member

stof commented Jul 9, 2014

Please put the test in the same PR, not in a different one

@stof
Copy link
Member

stof commented Jul 9, 2014

no need to close this PR. You can simply push new commits to the same branch (but reopen it before pushing otherwise they won't be taken into account)

@janschoenherr
Copy link
Contributor Author

Thanks, will do next time. I've created a new pullrequest here: #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AnnotationReader does not read first array into "value"
2 participants
@janschoenherr @stof