Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnnotationReader does not read first array into "value" #326

Closed
janschoenherr opened this issue Jul 9, 2014 · 3 comments · Fixed by doctrine/annotations#38
Closed

AnnotationReader does not read first array into "value" #326

janschoenherr opened this issue Jul 9, 2014 · 3 comments · Fixed by doctrine/annotations#38
Assignees
@Ocramius

Comments

@janschoenherr
Copy link

@Foo({....}, bar="x")

I would expect to get an array with:

['value' => {....}, 'bar' => 'x'],

instead it throws an Exception:

AnnotationException in AnnotationException.php line 42:
[Syntax Error] Expected Doctrine\Common\Annotations\DocLexer::T_CLOSE_PARENTHESIS

However this seems to work fine: @Foo("test", bar="x")
This was referenced Jul 9, 2014
Closed
Closed
janschoenherr added a commit to janschoenherr/annotations that referenced this issue Jul 9, 2014
@janschoenherr
fixes doctrine/common#326
ec34112
@janschoenherr janschoenherr mentioned this issue Jul 9, 2014
Merged
@Ocramius
Copy link
Member

Ocramius commented Jul 9, 2014

Moved to doctrine/annotations#38

@Ocramius Ocramius closed this as completed Jul 9, 2014
@Ocramius Ocramius self-assigned this Jul 9, 2014
guilhermeblanco added a commit to doctrine/annotations that referenced this issue Jul 10, 2014
@guilhermeblanco
Merge pull request #38 from janschoenherr/master
0db097b 
fixes doctrine/common#326
@guilhermeblanco
Copy link
Member

Done as of doctrine/annotations@0db097b

@janschoenherr
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ocramius Ocramius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes doctrine/common#326 janschoenherr/annotations
Update DocParser.php
3 participants
@Ocramius @guilhermeblanco @janschoenherr